Fixed command examples #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--connection` parameter needs to be present for connection string otherwise default connection is made
benjie
approved these changes
Nov 21, 2016
|
(Just waiting for the build to pass so I can merge it) |
|
It seems Travis had a bit of a backlog issue earlier, there's no indication it received the webhook for this push. https://www.traviscistatus.com/ I'm going to edit a character to trigger a rebuild. |
|
Still no sign of it https://travis-ci.org/calebmer/postgraphql/pull_requests |
|
Ohhhhhhhhhhhhhh My bad. I broke the config. |
|
In conclusion, for tests to run against master for greenkeeper we need "build pushes" turned on; for tests to run on remote pull requests we need "build pull requests" turned on. For local pull requests (e.g. from contributors) every commit in a PR will thus be built twice and there doesn't seem to be a way to prevent that. |
Belline
pushed a commit
to Belline/postgraphql
that referenced
this pull request
Dec 18, 2017
`--connection` parameter needs to be present for connection string otherwise default connection is made
benjie
pushed a commit
that referenced
this pull request
Jan 27, 2020
Fixes #244 Uses a template string to support multiple PostgreSQL versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--connectionparameter needs to be present for connection string otherwise default connection is made